This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR other/44286, with mips, sparc, C++, Fortran, gcov, frontend bits
- From: NightStrike <nightstrike at gmail dot com>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org, rdsandiford at googlemail dot com
- Date: Mon, 7 Jun 2010 12:19:14 -0400
- Subject: Re: [PATCH] PR other/44286, with mips, sparc, C++, Fortran, gcov, frontend bits
- References: <20100531053427.GA8140@gmx.de> <87ocfvykud.fsf@firetop.home>
On Mon, May 31, 2010 at 2:42 PM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
>> I glanced at code places matching ', *\.\.\. *)'.
>>
>> Bootstrapped x86_64-unknown-linux-gnu, regtest is running. ?I still need
>> to test the mips and sparc changes.
>>
>> Only question I have is whether an ATTRIBUTE_SENTINEL_N(N) is preferable
>> to ATTRIBUTE_SENTINEL_1. ?sentinel and sentinel(N) were introduced in
>> the same GCC version AFAICS.
>>
>> There are a few more functions which use an integer zero sentinel, but
>> only where all vararg arguments are integers, so it doesn't make sense
>> to change that just so the attribute applies.
>>
>> OK to commit if no regressions show up?
>
> The MIPS parts are OK, thanks.
>
> Richard
>
Ping for the rest of this patch.
Bug still open: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44286