This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: An unreviewed ARM patch


Hi Richard,

Could someone please review the following patch?

   [patch] arm: Improve arm_rtx_costs_1 for Thumb2.
   http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00958.html


Hmm, I agree that there's probably some code in the rest of the MINUS case that should be shared. I'm not convinced, however, that we should fall through into the PLUS case: most of the code from that point on will only apply if we have RSB (and we don't in Thumb-2).

So maybe the check should be moved to the end of the MINUS code (ie just
before the fall-through) and then simplified to remove the sub-cases
that have already been handled.

Thank you for a review. I'll revise the patch accordingly.


Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]