This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR44363: gcc fails with ICE when compiling ffmpeg
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Sebastian Pop <sebpop at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Guenther <rguenther at suse dot de>
- Date: Tue, 1 Jun 2010 20:48:23 +0200
- Subject: Re: [patch] Fix PR44363: gcc fails with ICE when compiling ffmpeg
- References: <AANLkTiniT-H94wDpOR80qJs5Sti7USApDpdPdAy1KYyG@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jun 01, 2010 at 01:17:55PM -0500, Sebastian Pop wrote:
> the attached patch should fix the PR44363 by failing the if-conversion
> analysis in a more safe way, returning "analysis failed" instead of calling
> the ICE-ing gcc_unreachable. I will regstrap this patch if there are no
> concerns about this. Ok for trunk after regstrap passes?
I see that predicate_bbs resets all debug stmts right away.
Isn't that premature to do it when just checking whether the optimization
cab be performed or not? There are several cases after that reset which
can decide the optimization is not possible, and then we just needlessly
lost debug info quality.
Jakub