This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bootstrap issues with C++

Richard Guenther wrote:

>>> + #if GCC_VERSION >= 4000 && HAVE_DESIGNATED_INITIALIZERS
>>>     static bool reinit;
>>> + #endif
> 
> Well - it's pre-existing, this just completes it to avoid
> unused or set-but-not-used warnings.

How are designated intializers relevant?

> The above is the bool vs. int issue.  flag_pedantic_errors = pedantic = 1
> is treated as truth-value and thus we emit a warnign that suggests
> parantheses.

I think the change is fine, but it would be helpful if people posting
fixes for C++ compilation issues can explain them.  That will people
learn bits of "how C++ is not quite a superset of C" by osmosis.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]