This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Graphite] Add analysis pass to build the refined program structure tree.
- From: Sebastian Pop <sebpop at gmail dot com>
- To: Tobias Grosser <grosser at fim dot uni-passau dot de>
- Cc: gcc-patches at gcc dot gnu dot org, antoniu dot pop at mines-paristech dot fr, kargov at gmail dot com, gcc-graphite at googlegroups dot com
- Date: Wed, 26 May 2010 17:42:26 -0500
- Subject: Re: [Graphite] Add analysis pass to build the refined program structure tree.
- References: <1274912158-5453-1-git-send-email-grosser@fim.uni-passau.de>
On Wed, May 26, 2010 at 17:15, Tobias Grosser <grosser@fim.uni-passau.de> wrote:
> @Sebastian: Can I commit this for testing to the graphite branch?
Yes if you fix some formatting issues: please post an updated patch.
> +/* Print REGION to F indented by 2 * INDENT spaces. ?*/
> +void
> +print_refined_region (FILE *F, refined_region_p region, int indent)
You need an extra line between the comment and the function.
> +/* Functions to map from a basic block to a region. */
Dot space space.
> +}
> +
> +static inline void
> +insert_new_bb (basic_block key, basic_block value, htab_t bb_map)
> +{
Every function needs a comment.
> +static refined_region_p
> +create_region (basic_block entry, basic_block exit, refined_region_p parent, htab_t bbmap)
Please watch the length of the lines.
> +static void find_regions (bitmap *dfs, htab_t bbmap) {
This open brace should go on the next line.
> +static refined_region_p
> +get_topmost_parent(refined_region_p region) {
Missing space between function name and open paren.