This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] annotate library calls, part 1
- From: Tobias Burnus <burnus at net-b dot de>
- To: Daniel Franke <franke dot daniel at gmail dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 25 May 2010 16:18:46 +0200
- Subject: Re: [patch, fortran] annotate library calls, part 1
- References: <201005122052.45338.franke.daniel@gmail.com>
On 05/12/2010 08:52 PM, Daniel Franke wrote:
> Attached patch annotates the library calls in trans-decl.c and trans-io.c with
> noclobber/noescape attributes. That is, those in trans-io are dummies only,
> literally just "....", so somebody who knows the internals can fill them in
> easily wherever feasible.
>
Some comments:
I think the "fn spec" is wrong for "ttynam" (".RW" but first argument is
also written two), "fdate" (last argument is written to), ctime
(read/write seems to be swapped).
I think for size0 and size1 one can use "R" instead of just "r".
You should also update the patch for the newly add stop..._f2008
functions (in terms of formatting) - annotating the stop* functions is
kind of pointless though harmless as they do not return.
set_arg's "..R" is also wrong as the pointer escapes ...
The generate_local_decl part changes seem to be part of a different patch.
(And: I personally do not like the trans-io.c change of addinging lots
of pointless "..."; it is nice to have the pre-patch available (to save
time for the real implementation), but until then, maybe one better
keeps the current version.)
Tobias