This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c/25880 improve message of warning for discarding qualifiers
On 24 May 2010 13:47, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Mon, 24 May 2010, Manuel López-Ibáñez wrote:
>
>> I sometimes forget that humans cannot read minds. Now with patch.
>>
>> Manuel.
>>
>> On 24 May 2010 11:38, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
>> > Before updating testcases, I would like to know if the current patch is ok.
>> >
>> > Bootstrapped and regression tested on x86_64-linux-gnu. Failing
>> > testcases are due to the change of wording.
>
> I think you should print "const" as an attribute for functions, like
> volatile; otherwise the changes look OK. ?Note that you should update the
Do you mean?
+ pp_c_ws_string (pp, func_type ? "__atribute__((const))" : "const");
+ previous = true;
Does it work the same for C++? This function is shared between the two FEs.
> tests of GCC format checking (gcc.dg/format/gcc_diag-1.c) to test the new
> formats, as well as updating tests that fail.
Of course.
Cheers,
Manuel.