This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [build] Avoid use of unportable grep -q

From: Jason Merrill <jason at redhat dot com>
To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
Date: Fri, 21 May 2010 11:46:39 -0400
Subject: Re: [build] Avoid use of unportable grep -q
References: <yddhbmfapqj.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

On 05/10/2010 08:46 AM, Rainer Orth wrote:

During a recent build on Solaris 8 and 9 with only the native tools, I
noticed that a couple of uses of grep -q have crept in, which is
unportable according to the Autoconf manual, and not supported by
Solaris /usr/bin/grep.

The following patch fixes some of them.  The remaining uses are in
config.guess (which would have to be fixed upstream first, but only
affects NetBSD, HP-UX and Linux) and config/tcl.m4, which is probably
unused at least in the GCC side of the tree, so I've left them alone.

Ok for mainline, 4.5 and 4.4 branches?

I think you probably want to use >/dev/null 2>&1 to redirect stderr as well. OK with that change.

Jason

Follow-Ups:
- Re: [build] Avoid use of unportable grep -q
  - From: Rainer Orth

References:
- [build] Avoid use of unportable grep -q
  - From: Rainer Orth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]