This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] GCC symdb (libcpp/) 1 of 2
- From: Tom Tromey <tromey at redhat dot com>
- To: Yunfeng ZHANG <zyf dot zeroos at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Date: Wed, 19 May 2010 09:49:07 -0600
- Subject: Re: [PATCH] GCC symdb (libcpp/) 1 of 2
- References: <4df04b841001062118l4dbfde9dw2cf30b3aa38ab711@mail.gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> ">" == Yunfeng ZHANG <zyf.zeroos@gmail.com> writes:
>> * include/cpplib.h (struct cpp_callbacks): Add new callbacks.
>> macro_start_expand, macro_end_arg, macro_intern_expand,
>> macro_end_expand
>> comment
>> start_directive, end_directive
>> directive_token
The formatting of this part of the ChangeLog is odd.
I don't have a problem with adding hooks, in general.
I think it would be nice if we had some kind of "unlikely" macro, so we
could micro-optimize the tests. I don't know whether this really
matters or not; it would be nice to know whether this patch affects
libcpp performance.
>> (struct cpp_token): Add file_offset field.
This part of the patch is not ok.
First, cpp_token is space-sensitive. So, growing it requires
justification.
The new field has no comment. I don't know what it means.
Tom