This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix PR44119


Yet another missed necessary marking.

Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.

Richard.

2010-05-14  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/44119
	* tree-ssa-pre.c (eliminate): Properly mark replacement of
	a PHI node necessary.

	* gcc.c-torture/compile/pr44119.c: New testcase.

Index: gcc/tree-ssa-pre.c
===================================================================
*** gcc/tree-ssa-pre.c	(revision 159389)
--- gcc/tree-ssa-pre.c	(working copy)
*************** eliminate (void)
*** 4347,4352 ****
--- 4347,4356 ----
  
  	  remove_phi_node (&gsi, false);
  
+ 	  if (!bitmap_bit_p (inserted_exprs, SSA_NAME_VERSION (res))
+ 	      && TREE_CODE (sprime) == SSA_NAME)
+ 	    gimple_set_plf (SSA_NAME_DEF_STMT (sprime), NECESSARY, true);
+ 
  	  if (!useless_type_conversion_p (TREE_TYPE (res), TREE_TYPE (sprime)))
  	    sprime = fold_convert (TREE_TYPE (res), sprime);
  	  stmt = gimple_build_assign (res, sprime);
Index: gcc/testsuite/gcc.c-torture/compile/pr44119.c
===================================================================
*** gcc/testsuite/gcc.c-torture/compile/pr44119.c	(revision 0)
--- gcc/testsuite/gcc.c-torture/compile/pr44119.c	(revision 0)
***************
*** 0 ****
--- 1,46 ----
+ typedef signed char int8_t;
+ typedef short int int16_t;
+ typedef int int32_t;
+ typedef unsigned int uint32_t;
+ static int8_t
+ safe_mul_func_int16_t_s_s (int16_t si1, int8_t si2)
+ {
+   return si1 && si2 && si1 > +si2 || si1 && si2 && si2 < +si1 || si1 && si2
+     && si1 < +si2 || si1 && si2 && si1 && si2 < +si1 ? : si1 * si2;
+ }
+ 
+ struct S0
+ {
+ };
+ int32_t g_72[7][4][1];
+ int32_t *g_184 = &g_72[1][2][0];
+ int32_t **g_224 = &g_184;
+ struct S0 g_244 = {
+ };
+ 
+ int8_t *
+ func_96 (int8_t p_97, uint32_t p_98, uint32_t p_99)
+ {
+   struct S0 *l_243 = &g_244;
+   int i;
+   for (i = 0; i < 1; p_98 = 1)
+     {
+       int32_t *l_202[3];
+       int i;
+       for (i = 0; i < 1; i++)
+         l_202[i] = &g_72[2][2][0];
+       if (safe_mul_func_int16_t_s_s (0xCAF0, **g_224))
+         {
+           if (p_98 && &l_243)
+             {
+             }
+           else
+             *g_224 = l_202[0];
+           for (0;; 1)
+             {
+             }
+         }
+     }
+   return 0;
+ }
+ 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]