This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Provide debug info for SRA optimized variables (PR debug/43983)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Richard Guenther <rguenther at suse dot de>, Alexandre Oliva <aoliva at redhat dot com>, gcc-patches at gcc dot gnu dot org, Roland McGrath <roland at redhat dot com>, Jan Kratochvil <jkratoch at redhat dot com>
- Date: Wed, 12 May 2010 21:33:02 +0200
- Subject: Re: [PATCH] Provide debug info for SRA optimized variables (PR debug/43983)
- References: <20100506154114.GT2817@tyan-ft48-01.lab.bos.redhat.com> <4BEAF792.8050205@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, May 12, 2010 at 02:46:42PM -0400, Jason Merrill wrote:
> So, in this patch you're changing the var_loc_note field to be
> either a varloc note or a piece EXPR_LIST that does not appear
> anywhere else in the compiler, correct? Please document this new
> data structure.
Yeah. I can change even the field name to something else (suggestions?),
and will add the documentation.
> This code:
>
> And this code:
>
> are very similar. Can we factor this out into another function?
Yeah, they are similar, but there are lots of differences too (primarily,
the first sequence modifies an existing chain, while the second one is
copying another chain and doing the same modifications on it as the
first sequence would do. Doing a forceful copy and then just applying
the first sequence would work too, but would waste memory.
I'll try to see if merging both wouldn't be less maintainable than
the two separate sequences.
Jakub