Re: [PATCH] Adjust TREE_ADDRESSABLE comments that it applies to PARM_DECLs and RESULT_DECLs as well

[Richard Guenther <richard dot guenther at gmail dot com>]

On Fri, May 7, 2010 at 4:07 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> TREE_ADDRESSABLE isn't allowed from decls just on VAR_DECL, FUNCTION_DECL,
> FIELD_DECL and LABEL_DECL (where on the last of these it means something
> different from the rest), but also on PARM_DECLs and RESULT_DECLs at least.
> The following patch adjusts comments.
>
> Ok for trunk? ?Not tested.

Ok.

Thanks,
Richard.

> 2010-05-07 ?Jakub Jelinek ?<jakub@redhat.com>
>
> ? ? ? ?* tree.h (TREE_ADDRESSABLE): Adjust comment to say that
> ? ? ? ?this is also meaningful on PARM_DECLs and RESULT_DECLs.
>
> --- gcc/tree.h.jj ? ? ? 2010-05-06 18:17:24.000000000 +0200
> +++ gcc/tree.h ?2010-05-07 13:41:32.000000000 +0200
> @@ -411,7 +411,8 @@ struct GTY(()) tree_common {
> ? ?addressable_flag:
>
> ? ? ? ?TREE_ADDRESSABLE in
> - ? ? ? ? ? VAR_DECL, FUNCTION_DECL, FIELD_DECL, LABEL_DECL
> + ? ? ? ? ? VAR_DECL, PARM_DECL, RESULT_DECL, FUNCTION_DECL, FIELD_DECL
> + ? ? ? ? ? LABEL_DECL
> ? ? ? ? ? ?all types
> ? ? ? ? ? ?CONSTRUCTOR, IDENTIFIER_NODE
> ? ? ? ? ? ?STMT_EXPR, it means we want the result of the enclosed expression
> @@ -1106,8 +1107,8 @@ extern void omp_clause_range_check_faile
>
> ?/* Define many boolean fields that all tree nodes have. ?*/
>
> -/* In VAR_DECL nodes, nonzero means address of this is needed.
> - ? So it cannot be in a register.
> +/* In VAR_DECL, PARM_DECL and RESULT_DECL nodes, nonzero means address
> + ? of this is needed. ?So it cannot be in a register.
> ? ?In a FUNCTION_DECL, nonzero means its address is needed.
> ? ?So it must be compiled even if it is an inline function.
> ? ?In a FIELD_DECL node, it means that the programmer is permitted to
>
> ? ? ? ?Jakub
>