This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gc-improv merge (1/n): new libiberty interfaces
2010/5/6 DJ Delorie <dj@redhat.com>:
>
> As was noted, needs a space before the paren.
OK.
>
> I like descriptive names ("I should have spelled creat with an 'e'")
> but those do sound clumsy. ÂPerhaps something with "typed" in the
> name? Âsplay_tree_new_typed ? Âsplay_tree_new_typed_alloc ?
Having thought a little about this, I agree that "typed" is more
intuitive thanÂ"separate" (what is separate from what?).
How about
htab_create_typed_alloc
splay_tree_new_typed_alloc
?
> You need to document the new functions.
The patch already comments them. Should I just regenerate functions.texi?
> You've changed a public API. ÂHave you checked *every* project that
> uses libiberty to see if anyone uses the old API?
The patch only adds new API. The old API is not deprecated nor
changed. Am I missing something here?
Thank you,
--
Laurynas