This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PING plugin, C FE maintainers] Re: [PATCH] GCC symdb (gcc/) 2 of 2
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Yunfeng ZHANG <zyf dot zeroos at gmail dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 05 May 2010 20:29:19 +0100
- Subject: [PING plugin, C FE maintainers] Re: [PATCH] GCC symdb (gcc/) 2 of 2
- References: <4df04b841001062120k21699fcbwe9fa771933a6415f@mail.gmail.com> <4df04b841001111824o6972874bw7d9f04c6905a855a@mail.gmail.com> <4df04b841001171822j3cfae831u1a336e05f63b683d@mail.gmail.com> <4B54282C.3000302@gmail.com> <Pine.LNX.4.64.1001181323170.14357@digraph.polyomino.org.uk> <r2k4df04b841004201906ld9f6c035x90f34c7488414fe2@mail.gmail.com> <g2i4df04b841004201908q932ebe84yeb1d9e010ddcf4a6@mail.gmail.com> <z2l4df04b841004221832y4b7e2f7qa46d6e067f973d61@mail.gmail.com> <w2u4df04b841004221833u23adfe8azd161fb68fc070d9a@mail.gmail.com> <4BDB51FF.5070102@gmail.com> <t2r4df04b841005041904g7ee2cfb5gea43da6d2d01f137@mail.gmail.com>
On 05/05/2010 03:04, Yunfeng ZHANG wrote:
> gcc/ChangeLog is in http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00306.html,
> the whole patch includes two parts -- msg00306.html and ms00307.html. The first
> includes patch description, my change on libcpp/ and my gcc plugin code/test
> (attachment), later is for gcc/.
Oh, I forgot! However there are minor style issues with the changelog as it
stands: the convention is not to write multiple names in the brackets but to
write a separate entry for each item, and the comments are meant to say only
what we have done, but not why we did it. You could rewrite your original
one, or feel free to use my suggestion; I think they both say pretty much the
same thing.
>> Joseph, I don't have a fencepost account yet; can you verify that YZ's
>> paperwork has been processed, and if so review the original patch at:
>> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00307.html
I have now got an account and have verified that the paperwork is complete,
so we just need a plugin maintainer and a C front-end maintainer to approve
the relevant parts of the changes. The original patch is posted at
http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00307.html
and looks OK to me but I cannot approve it. Ping?
cheers,
DaveK