This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Clean up dwarf2out.c


On Fri, Apr 30, 2010 at 11:54 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> 2010/4/30 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>> 2010/4/29 Anatoly Sokolov <aesok@post.ru>:
>>> Hi,
>>>
>>> ?This patch add rtx_to_double_int functions in the GCC and do clean up
>>> dwarf2out.c.
>>>
>>> ?Bootstrapped/regtested on x86_64-unknown-linux-gnu, OK for mainline?
>>>
>>> ? ? ? ?* double-int.h (rtx_to_double_int): Declare.
>>> ? ? ? ?* double-int.c: Include rtl.h.
>>> ? ? ? ?(rtx_to_double_int): New function.
>>
>> Is double-int.h using rtx.h or the other way around? For modularity's
>> sake, this function should go to rtx.h, so you should not need to add
>> rtl.h to double-int.c.
>
> It follows existing practice with tree_to_double_int.

Maybe tree_to_double_int should be moved then?

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]