This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR bootstrap/43935: [4.6 regression] Revision 158896 fails to bootstrap
On Thu, Apr 29, 2010 at 9:08 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Thu, Apr 29, 2010 at 5:56 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> Hi,
>>
>> This patch fixes bootstrap on Linux/x86-64. ?OK to install?
>
> That's ... odd. ?Can you explain?
I think there is bug somewhere in inlining/debug where a declaration
within a function may change inline decision. I will see if I can find a
small testcase.
> Anyway, the patch is ok if it indeed fixes bootstrap.
Done.
H.J.
---
> Thanks,
> Richard.
>
>> Thanks.
>>
>>
>>
>> H.J.
>> ---
>> 2010-04-29 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>
>> ? ? ? ?PR bootstrap/43935
>> ? ? ? ?* plugin.h (flag_plugin_added): Moved out of
>> ? ? ? ?invoke_plugin_callbacks.
>>
>> diff --git a/gcc/plugin.h b/gcc/plugin.h
>> index 94663dd..3269641 100644
>> --- a/gcc/plugin.h
>> +++ b/gcc/plugin.h
>> @@ -35,6 +35,8 @@ extern void print_plugins_versions (FILE *file, const char *indent);
>> ?extern void print_plugins_help (FILE *file, const char *indent);
>> ?extern void finalize_plugins (void);
>>
>> +extern bool flag_plugin_added;
>> +
>> ?/* Called from inside GCC. ?Invoke all plugin callbacks registered with
>> ? ?the specified event.
>> ? ?Return PLUGEVT_SUCCESS if at least one callback was called,
>> @@ -49,8 +51,6 @@ invoke_plugin_callbacks (int event ATTRIBUTE_UNUSED,
>> ?{
>> ?#ifdef ENABLE_PLUGIN
>> ? /* True iff at least one plugin has been added. ?*/
>> - ?extern bool flag_plugin_added;
>> -
>> ? if (flag_plugin_added)
>> ? ? return invoke_plugin_callbacks_full (event, gcc_data);
>> ?#endif
>>
>