This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/43921: Bootstrap comparison fails when using -march=atom
On Thu, Apr 29, 2010 at 12:48 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Apr 28, 2010 at 12:09 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> @@ -26765,7 +26765,7 @@ extended_reg_mentioned_1 (rtx *p, void *data ATTRIBUTE_UNUSED)
>>>> ?bool
>>>> ?x86_extended_reg_mentioned_p (rtx insn)
>>>> ?{
>>>> - ?return for_each_rtx (INSN_P (insn) ? &PATTERN (insn) : &insn,
>>>> + ?return for_each_rtx (NONDEBUG_INSN_P (insn) ? &PATTERN (insn) : &insn,
>>>> ? ? ? ? ? ? ? ? ? ? ?extended_reg_mentioned_1, NULL);
>>>> ?}
>>>
>>> This hunk is IMHO wrong, for NONDEBUG_INSN_P just PATTERN should be
>>> scanned and nothing else. ?The rest looks good to me, though you need
>>> someone to approve it.
>> I am testing this on Linux/x86. ?OK for trunk and 4.5 if no regressions?
OK. Please wait a couple of days before backporting the patch to 4.5.
BTW: Please put ChangeLog in the body of the message, outside the
attachment, to avoid non-searchable archived posts [1].
[1] http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01763.html
Thanks,
Uros.