This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: plugin event for C/C++ declarations


On Tue, Apr 27, 2010 at 5:23 PM, Diego Novillo <dnovillo@google.com> wrote:
> On 4/27/10 10:39 , Brian Hackett wrote:
>> Hi, can this patch be applied? ?Also, is it possible for this change
>> to make it into the 4.5 branch?
>
> I'm doing a final bootstrap today. ?Richard/Jakub should decide whether
> we can apply this in 4.5.

No please.

>> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00780.html

This adds a function call for _every_ decl, pushing/popping a timevar
even if no plugins are loaded.  That's triple bad.

So I object plugin callbacks in such frequently called places until
that issue is addressed.

Richard.

>
> Diego.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]