This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 18918 coarray patch 9/n: Allocatable array coarrays


Hi Tobias,

finally another review for your co-array work :)

Tobias Burnus wrote:
On 16 April 2010, Tobias Burnus wrote:
This patch adds support for allocatable _array_ coarrays. (Allocatable
_scalar_ coarrays are not yet supported.) I checked that the dimensions
are correctly written to the array descriptor.

Actually, I missed some cases - one which was even visible without looking at the dump (or using the still unimplemented (l,u)cobound). They previously failing tests are now part of coarray_12.f90 (and trans-array.c contains the fixes).

Build and currently regtesting on x86-64-linux; if successful:
OK for the trunk?

Ok, I just have one format suggestion:


+ if (n < rank + corank -1)

Missing space in "-1". (This is in gfc_array_init_size.) Also, in that if's body there seems to be an indentation mismatch (tabs vs. spaces?).

Thanks!

Daniel

--
Done:  Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Kni-Mon-Pri


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]