This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR43839 - libjava incorrectly uses -liconv in testsuite


On 23/04/2010 21:13, Tom Tromey wrote:
>>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
> 
>>> -    lappend cxxflags -shared-libgcc -lgcj -liconv
>>> +    eval lappend cxxflags "-shared-libgcc -lgcj $libiconv"
> 
> Dave> ... if you don't add either the quotes or the eval, doesn't it
> Dave> "just work"?
> 
> If $libiconv can be empty, then the plain form will add an empty element
> to the list.  The eval+quotes form won't.

  Ah.  Well, that's relevant in general, but in this particular case, I think
that it:

>  proc gcj_jni_get_cxxflags_invocation {} {
> +  global libiconv
>    global LIBJAVA
> +  if {$libiconv == ""} {
> +      set libiconv "-liconv"
> +  }

... should not be able to happen.  Still, can't hurt to code defensively.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]