This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Consistently generate widening multiplies
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: Richard Guenther <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Dorit Naishlos <DORIT at il dot ibm dot com>
- Date: Thu, 22 Apr 2010 08:43:25 -0700
- Subject: Re: Patch: Consistently generate widening multiplies
- References: <4B7B2373.9050305@t-online.de> <n2n84fc9c001004070353rd50c2f2aneac3b6acc8871d7c@mail.gmail.com> <4BCF3860.6070900@codesourcery.com>
On Wed, Apr 21, 2010 at 10:39 AM, Bernd Schmidt <bernds@codesourcery.com> wrote:
> Here's a new version of the patch. ?Other than addressing your review
> comments (ignoring the naming of the pass for now since as you said we
> can rename it anytime), I also had to fix expand_debug_expr not to
> generate invalid RTL, and I've decided to add a check for optab
> availability to the pass - this seems to be better for code generation
> on the whole.
>
> A version without the optabs check has been bootstrapped and regression
> tested on i686-linux one or two weeks ago; new tests now in progress. ?Ok?
>
>
gcc.target/i386/wmul-1.c is 32bit only. It fails on 64bit target:
Executing on host: /export/gnu/import/svn/gcc-test/bld/gcc/xgcc
-B/export/gnu/import/svn/gcc-test/bld/gcc/
/export/gnu/import/svn/gcc-test/src-trunk/gcc/testsuite/gcc.target/i386/wmul-1.c
-O2 -S -o wmul-1.s (timeout = 300)
PASS: gcc.target/i386/wmul-1.c (test for excess errors)
FAIL: gcc.target/i386/wmul-1.c scan-assembler-times imull 2
--
H.J.