This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re[4]: Add double_int_not, double_int_lshift and double_int_rshift functions.


2010/4/15 Anatoly Sokolov <aesok@post.ru>:
> Hi.
>
>> I think tree_to_double_int could be a macro in double-int.h, like
>
>> #define tree_to_double_int (cst) (TREE_INT_CST (cst))
>
>> as it is just a fancy name for that. ?The patch is ok, and the suggested
>> change is pre-approved.
>
>
> Bootstrapped/regtested on x86_64-unknown-linux-gnu, OK?

Ok.

Thanks!
Richard.

> ? ? ? ?* double-int.h (tree_to_double_int): Convert to macro.
> ? ? ? ?* double-int.c (tree_to_double_int): Remove.
>
>
> Index: gcc/double-int.c
> ===================================================================
> --- gcc/double-int.c ? ?(revision 158383)
> +++ gcc/double-int.c ? ?(working copy)
> @@ -842,18 +842,6 @@
> ? return r;
> ?}
>
> -/* Constructs long integer from tree CST. ?The extra bits over the precision of
> - ? the number are filled with sign bit if CST is signed, and with zeros if it
> - ? is unsigned. ?*/
> -
> -double_int
> -tree_to_double_int (const_tree cst)
> -{
> - ?/* We do not need to call double_int_restrict here to ensure the semantics as
> - ? ? described, as this is the default one for trees. ?*/
> - ?return TREE_INT_CST (cst);
> -}
> -
> ?/* Returns true if CST fits in unsigned HOST_WIDE_INT. ?*/
>
> ?bool
> Index: gcc/double-int.h
> ===================================================================
> --- gcc/double-int.h ? ?(revision 158383)
> +++ gcc/double-int.h ? ?(working copy)
> @@ -63,8 +63,11 @@
>
> ?tree double_int_to_tree (tree, double_int);
> ?bool double_int_fits_to_tree_p (const_tree, double_int);
> -double_int tree_to_double_int (const_tree);
>
> +/* Constructs long integer from tree CST. ?*/
> +
> +#define tree_to_double_int(cst) (TREE_INT_CST (cst))
> +
> ?/* Constructs double_int from integer CST. ?The bits over the precision of
> ? ?HOST_WIDE_INT are filled with the sign bit. ?*/
>
>
>
> Anatoly.
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]