This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch]: Add support of new __int128 type for targets having 128-bit integer scalar support
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nathan at codesourcery dot com
- Date: Thu, 15 Apr 2010 20:54:02 +0000 (UTC)
- Subject: Re: [patch]: Add support of new __int128 type for targets having 128-bit integer scalar support
- References: <s2x90baa01f1004080322k82ab08e0s4741cab8495c86a2@mail.gmail.com>
You don't appear to have addressed my previous review comments in this
patch version (for example, the point that __int128 should be handled like
int, void, _Bool etc., getting "two or more data types in declaration
specifiers" for use with those specifiers instead of having explicit
checks for all of them). Furthermore, there are changes to existing code
(patch hunks that just change whitespace, for example) that appear
irrelevant to the addition of __int128.
--
Joseph S. Myers
joseph@codesourcery.com