This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[Ada] Avoid back-and-forth jumps in the debugger
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Thu, 15 Apr 2010 12:18:42 +0200
- Subject: [Ada] Avoid back-and-forth jumps in the debugger
This avoids back-and-forth jumps in the debugger by slightly reorganizing the
generated code in some specific case (a call to a procedure with 2+ In Out
parameters passed by copy for which the actual parameters generate checks and
are "non-constant lvalues").
Tested on x86_64-suse-linux, applied on the mainline.
2010-04-15 Eric Botcazou <ebotcazou@adacore.com>
* gcc-interface/trans.c (call_to_gnu): Do not unnecessarily force
side-effects of actual parameters before the call.
--
Eric Botcazou
Index: gcc-interface/trans.c
===================================================================
--- gcc-interface/trans.c (revision 158365)
+++ gcc-interface/trans.c (working copy)
@@ -2778,7 +2778,12 @@ call_to_gnu (Node_Id gnat_node, tree *gn
gnu_name_list = tree_cons (NULL_TREE, gnu_name, gnu_name_list);
if (!(gnu_formal && TREE_CODE (gnu_formal) == PARM_DECL))
- continue;
+ {
+ /* Make sure side-effects are evaluated before the call. */
+ if (TREE_SIDE_EFFECTS (gnu_name))
+ append_to_statement_list (gnu_name, &gnu_before_list);
+ continue;
+ }
/* If this is 'Null_Parameter, pass a zero even though we are
dereferencing it. */
@@ -2849,22 +2854,11 @@ call_to_gnu (Node_Id gnat_node, tree *gn
if (length > 1)
{
- tree gnu_name;
-
/* The call sequence must contain one and only one call, even though
the function is const or pure. So force a SAVE_EXPR. */
gnu_call = build1 (SAVE_EXPR, TREE_TYPE (gnu_call), gnu_call);
TREE_SIDE_EFFECTS (gnu_call) = 1;
gnu_name_list = nreverse (gnu_name_list);
-
- /* If any of the names had side-effects, ensure they are all
- evaluated before the call. */
- for (gnu_name = gnu_name_list;
- gnu_name;
- gnu_name = TREE_CHAIN (gnu_name))
- if (TREE_SIDE_EFFECTS (TREE_VALUE (gnu_name)))
- append_to_statement_list (TREE_VALUE (gnu_name),
- &gnu_before_list);
}
if (Nkind (Name (gnat_node)) == N_Explicit_Dereference)