This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING Re: [PATCH] do not install float.h, stddef.h and stdarg.h for mingw-w64
- From: Ozkan Sezer <sezeroz at gmail dot com>
- To: Danny Smith <dansmister at gmail dot com>
- Cc: NightStrike <nightstrike at gmail dot com>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Kai Tietz <ktietz70 at googlemail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 15 Apr 2010 09:01:25 +0300
- Subject: Re: PING Re: [PATCH] do not install float.h, stddef.h and stdarg.h for mingw-w64
> On Wed, Apr 14, 2010 at 11:47 AM, Dave Korn
> <dave.korn.cygwin@googlemail.com> wrote:
> >
> > On 13/04/2010 23:13, NightStrike wrote:
> > > http://gcc.gnu.org/ml/gcc-patches/2010-01/msg01114.html
> >
> > Hmm, that patch does the same thing in float.h as in stdarg.h and stddef.h,
> > where Kai's email suggests that 32-bit mingw also overrides float.h. Looks
> > like a cut and pasteo, no?
> >
> > Also, ping Danny: you want to cast an eye over the patch?
> >
> > cheers,
> > DaveK
> >
> On mingw32, nothing is broken so I see no need for a fix. On mingw32,
> an #include_next in the mingw32 distro headers does the right thing
>
> This part of the 'fix':
>
> --- gcc/ginclude/float.h~ 2010-01-20 20:56:56.000000000 +0200
> +++ gcc/ginclude/float.h 2010-01-20 21:07:27.000000000 +0200
> @@ -236,3 +236,10 @@
> #endif /* __STDC_WANT_DEC_FP__ */
>
> #endif /* _FLOAT_H___ */
> +
> +#ifdef __MINGW32__
> +#include <_mingw.h>
> +#ifdef _MINGW64_VERSION_MAJOR
> +#include_next <float.h>
> +#endif
> +#endif
>
>
> breaks mingw32, since the mingw32 <float.h> already does
> #include_next <float.h> to get the compiler's gincluded float.h.
Well, this begs for an explanation: Since when mingw32 is defining
_MINGW64_VERSION_MAJOR in their headers? Otherwise I'd really like
to understand in which magical ways does it break mingw32.
>
>
> So my eye suggests that the patch is not acceptable
>
> Danny
--
Ozkan