This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Improve VLAs in Fortran debuginfo even at -O1+
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 14 Apr 2010 11:37:09 -0700
- Subject: Re: [PATCH] Improve VLAs in Fortran debuginfo even at -O1+
- References: <20100414183325.GC2817@tyan-ft48-01.lab.bos.redhat.com>
On Wed, Apr 14, 2010 at 08:33:25PM +0200, Jakub Jelinek wrote:
> Hi!
>
> This is something I've changed in gimplify.c for PR43150, but forgot
> that Fortran FE has similar stuff.
>
> Even for -O1 and above clearing DECL_IGNORED_P makes sense, as the variable
> can be then tracked by VTA and thus the debugger can get a location
> expression or location list for the size.
>
> One tiny issue left is (but that is for -O0 -g too) is that these
> artificial vars still have names like ubound.0 and those names show up in
> the debug info (the DIEs are DW_AT_artificial, but still). I guess it would
> make code less readable in the FE if we switched to some other names
> (__ prefixed or starting with . or something similar); one possibility is
> clear DECL_NAME of these vars when handing them over to middle-end (e.g.
> through a gimplify_expr langhook). It isn't a big deal, just that
> when e.g. looking for current variables starting with u you enter u and tab
> in the debugger and it will offer ubound.0 completion among other things.
>
> Ok for trunk?
>
> 2010-04-14 Jakub Jelinek <jakub@redhat.com>
>
> * trans-decl.c (gfc_build_qualified_array): Clear DECL_IGNORED_P
> on VAR_DECL LBOUND and/or UBOUND, even for -O1.
>
OK.
--
Steve