This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [DRAGONEGG] Expose 4 functions in i386.c
On 13/04/2010 18:29, Steven Bosscher wrote:
> On Tue, Apr 13, 2010 at 7:24 PM, Paolo Bonzini <bonzini@gnu> wrote:
>> On 04/13/2010 07:32 PM, Dave Korn wrote:
>>>> The question is whether it is nonetheless ok to apply this to the
>>>> gcc-4.5 branch in order to make things easier for my users, even
>>>> though it is technically the wrong thing to do in the long term.
>> "The wrong thing to do" referred to something in dragonegg, not in GCC.
>
> I think exposing these functions to the global GCC name space is also
> the wrong thing to do. And historically, once something is "fixed" the
> easy way in GCC, the proper fix is never implemented.
Yes, just to be clear, there was no political flame, that was a purely
engineering consideration about exposing internal APIs that cleanliness and
separation concerns suggest should for preference not be exposed. If
something is "the wrong thing to do" downstream, then adding support for it
upstream is just bound to seem correspondingly wrong.
> In this unusual case, it may even be "better" to put the patch on the
> release branch alone, and not on the trunk. That gives Duncan the
> opportunity to fix this properly in DragonEgg for GCC 4.6, while
> having a working interface in the released FSF GCC 4.5.1.
That sounds like a perfectly reasonable compromise.
cheers,
DaveK