Re: RFA/RFC: Enable both gold and ld in a single toolchain

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Apr 9, 2010 at 2:10 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Apr 9, 2010 at 11:52 AM, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
>> Hello H.J.,
>>
>> a very minor nit:
>>
>> * H.J. Lu wrote on Fri, Apr 09, 2010 at 07:45:11PM CEST:
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1483,7 +1483,7 @@ Optional Features:
>>
>>> - ?--enable-gold ? ? ? ? ? use gold instead of ld
>>> + ?--enable-gold[=ARG] ? ? build gold [ARG={both}[[/{gold,ld}]]]
>>
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>
>>> ?AC_ARG_ENABLE(gold,
>>> -[ ?--enable-gold ? ? ? ? ? use gold instead of ld],
>>> +[ ?--enable-gold[[=ARG]] ? ? build gold [[ARG={both}[[/{gold,ld}]]]]],
>>
>> For a consistent quoting style that expands to the desired number of
>> brackets, use either outer double quoting
>>
>> +[[ ?--enable-gold[=ARG] ? ? build gold [ARG={both}[/{gold,ld}]]]],
>>
>> (note: within double-quoted text no macros will be expanded),
>> or use quadrigraphs @<:@ and @:>@ which will always expand to one
>> literal bracket.
>>
>>> --- a/gold/configure.ac
>>> +++ b/gold/configure.ac
>>> @@ -38,6 +38,24 @@ AC_DEFINE_UNQUOTED(TARGET_SYSTEM_ROOT, "$sysroot",
>>
>>> +AC_ARG_ENABLE(gold,
>>> +[ ?--enable-gold[[=ARG]] ? ? build gold [[ARG={both}[[/{gold,ld}]]]]],
>>
>> Likewise here.
>>
>
> I will fix it.
>
> There are more problems:
>
> 1. ld.bfd is installed even when gold is disabled.
> 2. The old ld isn't removed before installing the new one.
>

Here is the updated patch. I fixed the above issues. Also
it uses link whenever possible with proper install
dependency. I tested it with

1. --enable-gold=yes
2. --enable-gold=both
3. --enable-gold=both/gold
4. Nothing

"make install" works correctly.


-- 
H.J.

Attachment: binutils-gold-8.patch
Description: Text document