This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: PATCH to c_sizeof_or_alignof_type for c++/42623

From: Jason Merrill <jason at redhat dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Fri, 09 Apr 2010 11:17:00 -0400
Subject: Re: RFA: PATCH to c_sizeof_or_alignof_type for c++/42623
References: <4BBF4192.7040408@redhat.com> <i2z84fc9c001004090812w8a8f0d22n143ef4b0d58148@mail.gmail.com>

On 04/09/2010 11:12 AM, Richard Guenther wrote:

On Fri, Apr 9, 2010 at 5:02 PM, Jason Merrill<jason@redhat.com> wrote:

In this function, other errors result in returning error_mark_node, but for
some reason an incomplete type wasn't doing so, which confused the template
code into thinking that it was OK to take sizeof such a type.

Tested x86_64-pc-linux-gnu. OK for trunk?


Looks good, but I'm not sure if I can approve it.  Do you have a
testcase to add?

Other than the testcase in the patch?

Jason

Follow-Ups:
- Re: RFA: PATCH to c_sizeof_or_alignof_type for c++/42623
  - From: Richard Guenther

References:
- RFA: PATCH to c_sizeof_or_alignof_type for c++/42623
  - From: Jason Merrill
- Re: RFA: PATCH to c_sizeof_or_alignof_type for c++/42623
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]