This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: PATCH to finalize_record_size to avoid ABI changes from -Wpacked (c++/41788)
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Apr 2010 17:10:42 +0200
- Subject: Re: RFA: PATCH to finalize_record_size to avoid ABI changes from -Wpacked (c++/41788)
- References: <4BBF40EE.1020600@redhat.com>
On Fri, Apr 9, 2010 at 4:59 PM, Jason Merrill <jason@redhat.com> wrote:
> Bug 41788 pointed out that -Wpacked changed the layout of a class by
> unsetting TYPE_PACKED when it seemed unnecessary. ?For 4.5 I fixed that bug
> by making it clear that the flag is actually necessary for that testcase,
> but in general it seems wrong for the compiler to change layout based on a
> warning flag. ?So this patch changes finalize_record_size to only give the
> warning, not actually unset the flag.
>
> Tested x86_64-unknown-linux-gnu. ?OK for trunk?
>
Ok.
Thanks,
RIchard.