This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: loop-invariant.c patch: Use validate_change to avoid breaking match_dup


> Mine avoids the recursive call to move_invariant_reg if the first
> attempt at validation fails.  If you are certain that that's irrelevant,
> I'll happily approve your version.

Yes, that's the main difference.  But what happens with your version if the 
replacement of the uses for the representative invariant succeeds, but fails 
later for one of its associated invariants?  Isn't that the same situation in 
the end?

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]