Re: [4.6 PATCH] -Wunused-but-set-{variable,parameter} (PR c/18624)

[Jakub Jelinek <jakub at redhat dot com>]

On Wed, Apr 07, 2010 at 11:59:54AM -0600, Tom Tromey wrote:
> >>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
> 
> Jakub> Here are updated patches for C -Wunused-but-set-* support,
> Jakub> bootstrapped/regtested on x86_64-linux and
> Jakub> i686-linux.  The C parts of the first patch have been approved
> Jakub> by Joseph already earlier, so I'm just seeking approval for the
> Jakub> rest of the changes.
> 
> Jakub> Ok for trunk?
> 
> The java front end changes seem a little ugly, but I don't see any
> better way to handle them, given that a lot of the code is in macros
> that are used in different contexts.

Yeah, the patch posted now was mostly about workarounds, the real fixes were
committed some months ago already.

> The only change I don't get is the classpath one.  Can we just remove
> 'rc'?  Upstream Classpath doesn't rely on GCC, so we'd need to
> conditionalize the attribute... but if we removed rc entirely then we
> could put the patch upstream as-is.

Changed.

Attached is what I've actually committed.

	Jakub

Attachment: Y470k
Description: Text document

Attachment: Y475e4
Description: Text document