This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch i386]: For 4.6 add support of thiscall calling convention attribute for x86

On Tue, 6 Apr 2010, Uros Bizjak wrote:
> +@item thiscall
> +@cindex functions that pop the argument stack on the 386
> +On the Intel 386, the @code{thiscall} attribute causes the compiler to
> +pass the first argument (if of integral type) in the register ECX.
> +Subsequent and other typed arguments are passed on the stack. The called
> +function will pop the arguments off the stack.
> +If the number of arguments is variable all arguments are pushed on the
> +stack.
> +The @code{thiscall} attribute is intended for C++ member this-methods.
> +As gcc extension this calling convention can be used for C-functions
> +and for static member methods.
> +
> I have CC'd Gerald, so he can say something about the grammar in the 
> above text.

Dave looks like a better person for that than me ;-), and he has done
a very nice review.

The one additional comment/question I have is whether it is "on the 386"
and "the Intel 386" or just "on 386" and "Intel 386".  Also, what is the
official name for that?  Perhaps say x86, or is this specific to 386 as
opposed to later generations?  

(I don't want to hold off application of this patch, just asking some


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]