This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [trans-mem] Re: [patch] handle new cgraph nodes in ipa-cp pass
> > Also note that the pass in beggining of all_regular_ipa_passes should be IPA_PASS
> > while at the new location should be SIMPLE_IPA_PASS.
> > PM will do right thing when you do otherwise but it will imply more passes over
> > the program running the analyze/transform methods if you get it wrong.
>
> Isn't it already so, or am I missing something?
>
> p = &all_regular_ipa_passes;
> NEXT_PASS (pass_ipa_whole_program_visibility);
> ...
>
> struct ipa_opt_pass_d pass_ipa_whole_program_visibility =
> {
> {
> IPA_PASS,
> ^^^^^^^^^
>
> p = &all_small_ipa_passes;
> NEXT_PASS (pass_ipa_function_and_variable_visibility);
> ...
> NEXT_PASS (pass_ipa_tm);
>
> struct simple_ipa_opt_pass pass_ipa_tm =
> {
> {
> SIMPLE_IPA_PASS,
> ^^^^^^^^^^^^^^^
Ah yes, it is correct. I was surprised you moved pass without changing its type,
but it was wrong previously.
Honza