This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR42617, alias-export and restrict pointers


On Wed, Apr 7, 2010 at 10:29 AM, Richard Guenther <rguenther@suse.de> wrote:
>> Actually, are you sure this patch doesn't break named address spaces?
>> I see calls to set_mem_addr_space in tree-ssa-loop-ivopts.c itself.
>> That will no longer work after your patch, IIUC.
>
> Indeed, but I doubt any target produces meaningful costs for them.

A grep for MEM_ADDR_SPACE in gcc/config/*/*.[ch] doesn't show anything
cost related, at least. So those set_mem_addr_space calls from
produce_memory_decl_rtl should just be removed if cost is the only
issue, I guess. (But be careful, I think that get_address_cost
actually looks at MEM_ADDR_SPACE via memory_address_addr_space_p...?)

Does IVOPTS still produce MEM_ATTRS if you remove those
set_mem_addr_space calls? Removing them may be enough if expand_expr
doesn't add MEM_ATTRS (and I don't think it does). The rest of IVOTPS
certainly doesn't touch or produce MEM_ATTRS.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]