This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH C] PR 36774 Don't warn missing prototype to nested functions if defined before first use
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Shujing Zhao <pearly dot zhao at oracle dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Paolo Carlini <paolo dot carlini at oracle dot com>
- Date: Tue, 6 Apr 2010 15:44:14 +0000 (UTC)
- Subject: Re: [PATCH C] PR 36774 Don't warn missing prototype to nested functions if defined before first use
- References: <4BB56DFF.firstname.lastname@example.org>
On Fri, 2 Apr 2010, Shujing Zhao wrote:
> -Wmissing-prototype should not trigger nested functions if defined before
> first use. -Wmissing-declaration also have the same problem.
> Only global def would be warn with no previous prototype or declaration if
> defined before first use, While the public_flag of nested function isn't be
> set to 0 before check the warn now. Move forward the check for nested function
> would solve this problem.
> Tested on i686-pc-linux-gnu, double checked the test cases with
> -Wmissing-prototype and -Wmissing-declaration, and no regression.
> Is it ok for 4.6?
OK for 4.6.
Joseph S. Myers