This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch,Fortran,4.6] Coarray 7/n - add -fcoarray=<none|single>


Tobias Burnus wrote:
This patch is rather simple compared with the others and justs add a new
compiler flag: -fcoarray=... with the options "none" (which is default)
and "single".

With "none" - the default -, the compiler gives an error message when
encountering a coarray declaration or an image control statement. This
gives the user a hint that the program uses coarrays; this helps to
reduce the change of running into the following problems:
(a) using a single image for programs which expects, e.g., at least two
images (this is the usage case which Nick mentioned)
(b) compiling one file with single-image support and the other one with
full, library-based coarray support, which can easily happen but leads
obviously to wrong code.

(Additionally, the -fcoarray= argument would have been added anyway for
the real parallel version.)

Build and regtested on x86-64-linux.
OK for the 4.6 trunk?

Ok. I like this :)


The only comment I have is that this "Co-Array disabled at..." message is used multiple times and will probably be more so if you update the expression patch accordingly (or add this later to it), and so maybe we could define the exact string once and use it at all those places? I know that this is nothing really common in the current codebase, so I think it is also ok as it is now.

Thanks!

Daniel

--
Done:  Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Kni-Mon-Pri


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]