This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR other/43620: Update to Automake 1.11.1.


On 04/02/2010 02:45 PM, Richard Guenther wrote:
On Thu, 1 Apr 2010, Ralf Wildenhues wrote:

Current GCC trunk will likely not upload to gnu.org which checks for
presence of an Automake 'make dist' rule security bug (GCC doesn't use
this rule).  See here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43620
http://sourceware.org/ml/binutils/2010-03/msg00452.html

There are a few alternative ways out for trunk:
1) remove all automake-generated dist rules from the build tree, GCC
    doesn't use them anyway,
2) upgrade to Automake 1.11.1,
3) convince gnu.org admins to reconsider the upload rules.

Patch below implements (2).  I will also post another patch that
implements (1) instead.  I consider both of them equally safe (haven't
heard of a regression of 1.11.1 over 1.11 yet), but (1) changes libjava,
classpath, libltdl, which are all upstream sources, and the changes are
not supposed for upstream (because they might actually want to use 'make
dist').

Below shown is only the non-regenerated part of the patch; attached find
the complete patch, gzip'ed.  The only part of this patch which isn't
completely trivial (yeah, famous last words) is that Automake 1.11.1
fixed AM_PROG_GCJ to use AC_CHECK_TOOLS instead of AC_CHECK_PROG for
finding gcj; but since the toplevel Makefile will export $(GCJ) in any
case, that shouldn't have any impact.

Bootstrapping finished, I've started a regtest but I don't see in which
way this patch could cause any fail at all (and it won't finish before
midnight over here).

OK to commit?

I'm ok with updating trunk to 1.11.1 from a RM perspective but can't approve the patch. Paolo?

Yes, thanks. I was waiting for a RM to comment.


Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]