This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/6] Devirtualization in ipa-cp

> @@ -531,6 +537,16 @@ ipcp_cloning_candidate_p (struct cgraph_
>    return true;
>  }
>  
comments ;) How this is different from BOTTOM in the lattice?

The patch overall seems to make sense.  Please add describing comment on the
top of ipa-cp as we are now diverging from classical ipa-cp formulation
somewhat (but I can't seem to justify separate devirtualization pass that would
do precisely the same as ipa-cp does but at types only)

I guess patch is Ok with the comment for pretty-ipa, we can deal with the
unnecesary clonning issue later.

Honza
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]