This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Review microblaze.md, required changes

From: Michael Eager <eager at eagercon dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 19 Feb 2010 12:35:23 -0800
Subject: Re: Review microblaze.md, required changes
References: <4B6B0699.6070702@eagercon.com> <4B6B50DE.5070506@redhat.com>

Richard Henderson wrote:

 > (define_insn "sext8"
 >   [(set (match_operand:SI 0 "register_operand" "=d")
 >         (sign_extend:SI (match_operand:QI 1 "register_operand" "d")))]
 >   "(GET_CODE(operands[1]) != MEM)"
Useless test vs MEM.
 > (define_insn "extendqidi2"
 > (define_insn "extendhidi2"
Delete these. They are *exactly* what you'd get from generic code, i.e. extension to SImode followed by extension to DImode.
 > (define_insn "sext8"
 > (define_expand "extendqisi2"
Merge these. I.e. delete the second and rename the first.
 > (define_insn "sext16"
 > (define_expand "extendhisi2"
Likewise.


Merged and renamed.
http://gcc.gnu.org/viewcvs?view=revision&revision=156809
or
svn diff svn://gcc.gnu.org/svn/gcc/branches/microblaze -r r156808:r156809

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

References:
- [PATCH] MicroBlaze support - 2 of 6 - backend
  - From: Michael Eager
- Review microblaze.md, required changes
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]