This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR32382 missed optimization in internal read - updated


Steven Bosscher wrote:
On Sat, Feb 13, 2010 at 9:38 PM, Jerry DeLisle <jvdelisle@verizon.net> wrote:

       PR fortran/32382
       * trans-stmt.h: Update function prototype for gfc_trans_code and
       gfc_trans_do, adding condition tree argument.

How about just adding a new function gfc_trans_code_with_cond as a wrapper around gfc_trans_code? That way, you don't have to update gfc_trans_cond everywhere.

I could do that. Any other opinions?

And you should add a comment before the function that explains the
function interface (i.e. what does cond mean?).


Certainly.


Regards,

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]