This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix --enable-checking=valgrind PCH failure
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 11 Feb 2010 13:10:38 -0700
- Subject: Re: [PATCH] Fix --enable-checking=valgrind PCH failure
- References: <20100211185956.GN2817@tyan-ft48-01.lab.bos.redhat.com>
On 02/11/10 11:59, Jakub Jelinek wrote:
The padding in v contains uninitialized garbage which we then write into
the PCH file. This isn't the only issue with --enable-checking=valgrind
and PCH, the other issue is that PCH dumps the full size of allocated
objects, even when they haven't been initialized at all (e.g. because token
size is 0), which triggers errors with the valgrind markups. Perhaps we'd
need to temporarily make the unaccessible fields defined and reset it back
or something similar.
Anyway, this one is the easy part, bootstrapped/regtested on x86_64-linux
and i686-linux, ok for trunk?
2010-02-11 Jakub Jelinek<firstname.lastname@example.org>
* c-pch.c (pch_init): Clear v.