This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: patch for PR42973

From: Jeff Law <law at redhat dot com>
To: Vladimir Makarov <vmakarov at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 09 Feb 2010 15:30:50 -0700
Subject: Re: RFA: patch for PR42973
References: <4B71BED0.8080405@redhat.com>

On 02/09/10 13:00, Vladimir Makarov wrote:

The following patch solves PR42973. The details can be found on

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42973

2010-02-09 Vladimir Makarov <vmakarov@redhat.com>
   PR middle-end/42973
   * ira-conflicts.c (get_dup): Remove.
   (process_reg_shuffles): Add new parameter.  Use it as an
   additional guard for copy generation.
   (add_insn_allocno_copies): Rewrite.
The patch is safe (I can not imagine that it can result in wrong code generation only if it triggers another bug). The patch was successfully bootstrapped on x86/x86_64.

Ok to commit?

Looks good to me and in my own sniff tests.

Note that pr 42973 is marked as a regression, so presumably we generated the desired code prior to IRA integration. So ISTM that the patch is fine to go into the tree now.

jeff

References:
- RFA: patch for PR42973
  - From: Vladimir Makarov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]