This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Fortran, Doc] PR fortran/41507: Correct misleading documentation about MINLOC and friends


Daniel,

The doc patch looks okay to me.  I have a larger set of
patches for file, but I haven't found time to fix an
issue with too many items in a multitable.  May be
this upcoming weekend.

-- 
steve

On Mon, Feb 08, 2010 at 09:16:50PM +0100, Daniel Kraft wrote:
> Hi all,
> 
> the intrinsics documentation currently claims that 
> MINLOC/MAXLOC/MINVAL/MAXVAL accepts an array argument of type CHARACTER. 
>  This is true in theory (since F2003 -- but it is also claimed that the 
> function is F95 without any note about that), but not yet supported.
> 
> I think the documentation should reflect what's actually available, so 
> the attached patch changes this.  Another suggestion could be to not 
> remove CHARACTER entirely but change it to something along the lines of
> 
> "INTEGER, REAL or CHARACTER type (but CHARACTER argument is not yet 
> supported by GFortran)"
> 
> My optinion is though that the current version is preferrable. 
> Obviously it would even be better to implement CHARACTER arguments, but 
> I think at the moment this patch is also a worthwhile improvement ;) 
> (I'm not sure if there's already a PR for this, but can create one if not.)
> 
> Ok for trunk?
> 
> Daniel
> 
> -- 
> Done:  Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
> To go: Hea-Kni-Mon-Pri

> 2010-02-08  Daniel Kraft  <d@domob.eu>
> 
> 	PR fortran/41507
> 	* intrinsic.texi (MAXVAL): Remove wrong claim that array argument
> 	can be CHARACTER type.
> 	(MINVAL), (MAXLOC), (MINLOC): Ditto.

> Index: gcc/fortran/intrinsic.texi
> ===================================================================
> --- gcc/fortran/intrinsic.texi	(revision 156447)
> +++ gcc/fortran/intrinsic.texi	(working copy)
> @@ -7558,8 +7558,8 @@ Transformational function
>  
>  @item @emph{Arguments}:
>  @multitable @columnfractions .15 .70
> -@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER},
> -@code{REAL}, or @code{CHARACTER}.
> +@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER} or
> +@code{REAL}.
>  @item @var{DIM}   @tab (Optional) Shall be a scalar of type
>  @code{INTEGER}, with a value between one and the rank of @var{ARRAY},
>  inclusive.  It may not be an optional dummy argument.
> @@ -7614,8 +7614,8 @@ Transformational function
>  
>  @item @emph{Arguments}:
>  @multitable @columnfractions .15 .70
> -@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER},
> -@code{REAL}, or @code{CHARACTER}.
> +@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER} or
> +@code{REAL}.
>  @item @var{DIM}   @tab (Optional) Shall be a scalar of type
>  @code{INTEGER}, with a value between one and the rank of @var{ARRAY},
>  inclusive.  It may not be an optional dummy argument.
> @@ -7869,8 +7869,8 @@ Transformational function
>  
>  @item @emph{Arguments}:
>  @multitable @columnfractions .15 .70
> -@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER},
> -@code{REAL}, or @code{CHARACTER}.
> +@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER} or
> +@code{REAL}.
>  @item @var{DIM}   @tab (Optional) Shall be a scalar of type
>  @code{INTEGER}, with a value between one and the rank of @var{ARRAY},
>  inclusive.  It may not be an optional dummy argument.
> @@ -7925,8 +7925,8 @@ Transformational function
>  
>  @item @emph{Arguments}:
>  @multitable @columnfractions .15 .70
> -@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER},
> -@code{REAL}, or @code{CHARACTER}.
> +@item @var{ARRAY} @tab Shall be an array of type @code{INTEGER} or
> +@code{REAL}.
>  @item @var{DIM}   @tab (Optional) Shall be a scalar of type
>  @code{INTEGER}, with a value between one and the rank of @var{ARRAY},
>  inclusive.  It may not be an optional dummy argument.


-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]