This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix typo causing PR42982 [typofixed, was 42892]
On Sat, Feb 06, 2010 at 02:10:01PM +0000, Dave Korn wrote:
> On 06/02/2010 08:09, Iain D Sandoe wrote:
> > On 6 Feb 2010, at 05:46, Jack Howarth wrote:
> >
> >>
> >> The changes to gcc/config/darwin.h and gcc/config/darwin9.h in
> >> r155534 accidentally omitted the trailing * causing the
> >> gcc.dg/profile-generate-3.c test case to fail on *-apple-darwin*.
> >> Adding this missing * eliminates the failure. Tested on
> >> x86_64-apple-darwin10 without regressions. Okay for gcc trunk?
>
> > Jack,
> > mea culpa...
> > ... fix looks OK to me (but not my call obviously).
> > Iain
>
> Well, I may be stretching slightly the boundaries of what's permitted here,
> but I will describe this as a partial (two characters!) reversion of the patch
> that I originally committed for Iain in the first place, and check it in.
> Darwin maintainers CC'd FYI.
>
> I'll commit the fix sometime later today when I get a spare ten minutes to
> update a sandbox.
>
> cheers,
> DaveK
Dave,
FYI, the results for regression testing on x86_64-apple-darwin10 before and
after the patch are at...
http://gcc.gnu.org/ml/gcc-testresults/2010-02/msg00481.html
and
http://gcc.gnu.org/ml/gcc-testresults/2010-02/msg00510.html
Jack