This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch][graphite]Add run time check and cleanup autopar test cases.
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Richard Guenther <richard dot guenther at gmail dot com>
- Cc: Li Feng <nemokingdom at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Graphite <gcc-graphite at googlegroups dot com>, Razya Ladelsky <RAZYA at il dot ibm dot com>
- Date: Fri, 04 Dec 2009 15:10:23 -0800
- Subject: Re: [patch][graphite]Add run time check and cleanup autopar test cases.
- References: <f18356030912040527l55f6e1eoa71a972592b72ae3@mail.gmail.com> <84fc9c000912040546u49306b21w5807e5064d190367@mail.gmail.com>
- Reply-to: janis187 at us dot ibm dot com
On Fri, 2009-12-04 at 14:46 +0100, Richard Guenther wrote:
> On Fri, Dec 4, 2009 at 2:27 PM, Li Feng <nemokingdom@gmail.com> wrote:
> > Hi,
> >
> > This patch add run time check for the testcases in autopar.
> > Add move all the checking options into *.exp file instead of
> > in each file.
> >
> > OK for trunk? Tested without bootstrapped.
>
> You should at least cleanup the dump files from the dg machinery
> as well. Note that setting DEFAULT_CFLAGS might have spurious
> effects elsewhere IIRC.
Right. Don't change DEFAULT_CFLAGS unless you also save and
restore the old value. You can just use a different variable,
like AUTOPAR_CFLAGS.
> And you need approval from a testsuite maintainer, CCing Janis.
There are changes to test autopar/outer-2.c that have nothing
to do with this patch. If those changes were intended, please
move them to a separate patch.
Tests pr39500-1.c and pr39500-2.c were not changed, was that on
purpose? They both have a "main" look as if they could be run.
With those changes the patch is OK with me, but wait for input
from Razya as well.
Janis