This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Libstdc++ as DLL on windows, alternative approach [was Re: cygwin patch review]
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Benjamin Kosnik <bkoz at redhat dot com>, libstdc++ at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>, Danny Smith <dansmister at gmail dot com>, "Aaron W. LaFramboise (GCC)" <aaronavay62 at aaronwl dot com>, Kai Tietz <ktietz70 at googlemail dot com>
- Date: Mon, 30 Nov 2009 20:28:17 +0000
- Subject: Re: Libstdc++ as DLL on windows, alternative approach [was Re: cygwin patch review]
- References: <20091019092452.2e271791@mcgee.artheist.org> <4AFC8EC3.10502@gmail.com> <20091119093347.797df3ff@mcgee.artheist.org> <4B06CAEA.5080705@gmail.com>
Dave Korn wrote:
> [snip]
YA test results:
http://gcc.gnu.org/ml/gcc-testresults/2009-11/msg02971.html
Owing to imminent end of stage I guess I'll just have to check it in without
this part for which I haven't been able to get review in time:
> * gcc.c (LINK_COMMAND_SPEC): Allow and ignore -static-libstdc++
> similarly to -static.
>
> gcc/cp/ChangeLog:
>
> * g++spec.c (SKIPOPT): Delete.
> (lang_specific_driver): Do not skip -static-libstdc++ option.
The end result won't be broken, the remaining parts of the patch will stand
alone, but it will lead to statically linked c++ code needlessly indirecting
through the cygwin dll malloc wrappers when it doesn't have to. That's a
small inefficiency that can be solved whenever the patch can be approved.
It's also eminently suitable to go in as a separate patch anyway, since it
helps fix someone else's PR too.
cheers,
DaveK