This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] Minipool ranges for thumb2_movdf_soft_insn
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, paul at codesourcery dot com
- Date: Fri, 27 Nov 2009 17:25:04 +0000
- Subject: Re: [PATCH, ARM] Minipool ranges for thumb2_movdf_soft_insn
- References: <20091127171115.14e1afe9@rex.config>
On Fri, 2009-11-27 at 17:11 +0000, Julian Brown wrote:
> Hi,
>
> This patch fixes (I believe) a typo in *thumb2_movdf_soft_insn, noticed
> when working on another patch. I've not noticed any ill effects from
> this, but it didn't look right to me.
>
> Tested with cross-compiler to ARM EABI.
>
> OK to apply?
>
> Julian
>
> ChangeLog
>
> gcc/
> * config/arm/thumb2.md (*thumb2_movdf_soft_insn): Fix pool ranges.
Hmm, I think you're right about this really needing '*' variants for the
non-literal pool variants, but wrong about the range.
This instruction should be generating an ldrd from the literal pool; by
increasing the range you make this impossible in some circumstances and
we could end up with a pair of load instructions. The fact that we
could fall back to two load instructions doesn't mean we should.
R.