This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems

From: Paolo Bonzini <bonzini at gnu dot org>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Gabriel Dos Reis <gdr at integrable-solutions dot net>
Date: Wed, 18 Nov 2009 03:55:56 +0100
Subject: Re: [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems
References: <4B025B89.6030500@oracle.com> <206fcf960911171816n1562a8dfl66b33b400def341e@mail.gmail.com>

>> I have made two candidate patches. One is to pass an enum

to this function and the other is pass the complete diagnostic text to it.
Which one is ok for trunk?

The second -- the one with enums.

Since you like the enum approach, what would you think of something like http://gcc.gnu.org/ml/gcc-patches/2002-06/msg01620.html ?

Paolo

Follow-Ups:
- Re: [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems
  - From: Joseph S. Myers

References:
- [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems
  - From: Shujing Zhao
- Re: [PATCH, PR c++/40892] Fix maybe_warn_cpp0x i18n problems
  - From: Gabriel Dos Reis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]