This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 3)


On 11/17/2009 01:54 AM, Jakub Jelinek wrote:
On Mon, Nov 16, 2009 at 11:06:36PM -0500, Jason Merrill wrote:
On 11/16/2009 12:41 PM, Jakub Jelinek wrote:
+    else if (DECL_NAME (clone) == deleting_dtor_identifier)
+      fns[2] = clone;

Why did you add the third slot to fns?

So that I can iterate over the array rather than in FOR_EACH_CLONE depend on whatever ordering is present there. For the alias handling I need the real function to be processed (including expand_or_defer_fn) before the alias.

Ah, ok.


also making the complete
cdtor to be the defined function and base cdtor be an alias to it.

I think I prefer having the base cdtor be the defined one, since it's conceptually a subroutine of the complete cdtor.

Ok. I'll swap fns[0] with fns[1] then.

OK with that change.


Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]